Skip to content

[skip changelog] Document "Library Name Priority" #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2021
Merged

[skip changelog] Document "Library Name Priority" #1301

merged 1 commit into from
May 28, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 28, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

docs update

  • What is the current behavior?

When multiple libraries contain files matching an #include directive, Arduino CLI must pick one. Multiple factors are
used in order to make an intelligent determination of which library is best. In order to enhance this determination, the
library.properties name value is now one of those factors (#1300). The other factors are already documented in the "Sketch Build Process" documentation, but this newly added feature was previously undocumented.

  • What is the new behavior?

The "Library Name Priority" dependency resolution factor is fully documented in the "Sketch Build Process" documentation,

No breaking

  • Other information:

I used the "Arduino Low Power" library in the examples rather than following the convention of using the "Servo" library because I wanted to make it clear how spaces are handled.

Related: #1292

When multiple libraries contain files matching an `#include` directive, Arduino CLI must pick one. Multiple factors are
used in order to make an intelligent determination of which library is best. In order to enhance this determination, the
library.properties `name` value is now one of those factors. The other factors are already documented in the "Sketch
Build Process" documentation, but this newly added feature was previously undocumented.
@per1234 per1234 requested review from cmaglie and silvanocerza May 28, 2021 12:42
@per1234 per1234 added the topic: documentation Related to documentation for the project label May 28, 2021
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@per1234 per1234 merged commit 5115d44 into arduino:master May 28, 2021
@per1234 per1234 deleted the lib-name-priority-docs branch May 28, 2021 20:57
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants